Skip to content

[main-lts] issue-1235: Token propagation is not working when the openapi endpoint contains a base path #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[main-lts] issue-1235: Token propagation is not working when the openapi endpoint contains a base path #1236

wants to merge 1 commit into from

Conversation

@wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Jul 9, 2025

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@wmedvede wmedvede requested a review from a team as a code owner July 9, 2025 17:43
@hbelmiro hbelmiro linked an issue Jul 9, 2025 that may be closed by this pull request
Token propagation is not working when the openapi endpoint contains a base path #1235
Open
@ricardozanini
Copy link
Member

ricardozanini commented Jul 9, 2025

@wmedvede please open this PR against main, we have automation to backport to main-lts branch.

@wmedvede wmedvede closed this Jul 10, 2025
@Miladiir
Copy link

Miladiir commented Sep 20, 2025

@ricardozanini We just hit this exact problem but without token propagation. Normal oauth client request filter is also affected by this missing feature. Is the code fine, so should I copy @wmedvede 's work and create a pull request against main?

@wmedvede
Copy link
Contributor Author

wmedvede commented Sep 22, 2025 •
edited
Loading

@Miladiir This PR finally wasn't merged. As part of my tests, I could finally see that the issue reported by the customer was happening becuase the openapi document they where using had no servers/base_path declared.

Customer had a openapi document like this 👇

servers:
  - url: /     <- NO servers/base path declared

...

paths:
  /refresh:  
    post:
        bla bla bla

  /entities:
    get:
       bla bla bla

However, the endpoints where published in the base path /api/catalog.
That openapi document generated the isssue, since the base path is taken from the url field at code generation time.

Solution:

The openapi document was modified to this, and the code was re-generated.

servers:
  - url: /api/catalog    <- Set the base path for the endpoints here

And you must configure the quarkus rest client like this:

quarkus.rest-client.my_openapi_yaml.url=http://my-server.com:8080/api/catalog <- include the base path

I hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardozanini ricardozanini Awaiting requested review from ricardozanini

@gmunozfe gmunozfe Awaiting requested review from gmunozfe

Assignees

No one assigned

Labels

backport-main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Token propagation is not working when the openapi endpoint contains a base path

4 participants

@wmedvede @ricardozanini @Miladiir @hbelmiro